-
-
Notifications
You must be signed in to change notification settings - Fork 21.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional macOS codesign entitlements and print verbose #98126
Additional macOS codesign entitlements and print verbose #98126
Conversation
Why is the pipeline unhappy? I read the error but I don't understand what it means. |
Looks like it wants you to add documentation for the new property. |
Thanks @cadence-s :) I've never added documentation before. So 2 questions:
Thanks! :) |
114acdd
to
d869a00
Compare
figured it out. thanks @cadence-s :) |
@cadence-s i lied. I thought I figured it out. It's still unhappy and I don't know why :( |
It thinks your formatting is wrong because there's a stray "+" character |
Thanks @cadence-s ! :) I'll fix that :) |
Run editor (compiled from your branch) from the repo root, with the You can also enable pre-commit hooks to run static checks (and automatically apply style fixes) locally. |
figured it out. thanks @cadence-s :)
Brilliant! Thank you! :) |
d869a00
to
5777a3f
Compare
Thanks! |
Absolutely! And thank you as well! :) |
This PR adds 2 additional things for macos exports:
codesign/entitlements/additional
property. This behaves similarly to theapplication/additional_plist_content
property for adding additional plist elements the godot editor gui doesn't cover.As always, Lange Studios thanks you for the awesome engine! Please let me know if you have any feedback on the PR or wish us to change anything :)